Tasotarkistus data to rent model #773
Conversation
|
I have questions about the model changes and what is needed for the initial UI changes, and what is needed in the future. Will discuss in a meeting with you. |
|
We talked with Jukka. There will likely be more changes coming to this PR when the UI implementation becomes more refined, especially the saving functionality. Then it becomes more apparent which properties need to be explicitly saved in database, and which ones can be derived from existing properties. For example, tasotarkistus type (20/20 or 20/10) must be saved along with the tasotarkistus, but maybe calculation dates can be derived from that type and the rent start date (e.g. 20 years from rent start date, then +10, then +10...). There is a feature request for notifications for upcoming tasotarkistus dates for the rents that have it in near future, maybe 3 years/2 years/1 year in advance. That notification implementation might be slow to execute without dedicated columns for tasotarkistus dates, where DB indexes could be created. But the first notification would happen sometime in the decade 2040, so this is probably just a suggestion in code rather than the final implementation. |
NC-jsAhonen
force-pushed
the
MVJ-421-periodic-price-index-to-rent-types
branch
from
3359d3e to
c13af49
Compare
NC-jsAhonen
force-pushed
the
MVJ-421-periodic-price-index-to-rent-types
branch
from
4467e63 to
4504ef8
Compare
| max_digits=8, | ||
| null=True, | ||
| ) | ||
|
|
There was a problem hiding this comment.
Then I think we need a 3rd new property: type of the tasotarkistus (20v/20v) or (20v/10v).
The Rent class is getting slightly populated, but it might still be OK because I just removed 4 fields about the seasonal rent.
Another possibility is to create a new model for PeriodicRentAdjustment which holds these 3 fields (index, adjustment type, and starting point figure). Then Rent would have a single ForeignKey property like periodic_rent_adjustment that can be null if the rent doesn't use the feature.
There was a problem hiding this comment.
What do you @henrinie-nc think?
NC-jsAhonen
force-pushed
the
MVJ-421-periodic-price-index-to-rent-types
branch
from
c77da90 to
c06e0c2
Compare
Add
old_dwellings_in_housing_companies_price_indexto rent model, to use tasotarkistus data on the Vuokrat tab.